-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings page updates #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
586c64f
to
92f3332
Compare
Every datasource configured from settings page has a unique UUID which is autogenerated. Thus it isn't available before the datasource is created and hence a user defined unique slug is need to associate configured datasources with datasources in code.
92f3332
to
5617f75
Compare
… update/settings-page
jblz
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just left a couple of spots where we need to update the translation calls.
jblz
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR includes changes to the data storage model for Data Sources, particularly for Airtable integration, and User Interface improvements for the settings page.
Data Source Storage Model
A new unique field
slug
is added to the data sources. This field is user configurable as opposed to theuuid
which is auto generated. This allows adding data sources in code and referencing them by the slug. Secrets for the data sources can be added in the settings page and can be linked to the data source by the slug.The
base
andtable
fields are updated to store both theid
andname
for the Airtable base and table. This allows for displaying the name in the UI and using the id in the API calls. The updated storage model for Airtable is -Settings Page UI Improvements
help
attribute for input elements to show extra information for the input like errors, hints, additional data fetched remotely after validation input.